Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-selector): added clear label attribute #4914

Merged
merged 5 commits into from
Jan 21, 2021
Merged

fix(language-selector): added clear label attribute #4914

merged 5 commits into from
Jan 21, 2021

Conversation

IgnacioBecerra
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra commented Jan 15, 2021 •
edited
Loading

Related Ticket(s)

#4889

Description

The component now has the role of edit combo to ensure the screen readers convey its purpose to the users. The clear button also lacked a label to convey functionality upon click/enter.

Changelog

New

  • added clear button label property

@IgnacioBecerra IgnacioBecerra added the package: web components Work necessary for the IBM.com Library web components package label Jan 15, 2021
@IgnacioBecerra IgnacioBecerra mentioned this pull request Jan 15, 2021
Closed
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 15, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4914/index.html

Built with commit: f8e0fa1a30e8fd7759649a762d7ca718c461dcfc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 15, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4914/index.html

Built with commit: f8e0fa1a30e8fd7759649a762d7ca718c461dcfc

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 15, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4914/index.html

Built with commit: f8e0fa1a30e8fd7759649a762d7ca718c461dcfc

asudoh
asudoh reviewed Jan 20, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @IgnacioBecerra thank you for trying to fix this - Would you want to try fixing this directly in carbon-web-components unless this needs to be included in v1.15.0?

@IgnacioBecerra
Copy link
Contributor Author

@asudoh Yeah, I think that's a good idea. I don't think we need to get this into the release right away, and besides this is a change that should be coming from ComboBox itself.

@IgnacioBecerra
Copy link
Contributor Author

There was a button label attribute for ComboBox, so that addition can be reflected on our side.

@IgnacioBecerra IgnacioBecerra changed the title fix(language-selector): improved accessibility fix(language-selector): added clear label attribute Jan 20, 2021
asudoh
asudoh approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @IgnacioBecerra for the update!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 21, 2021
@kodiakhq kodiakhq bot merged commit cce42f4 into carbon-design-system:master Jan 21, 2021
@jeffchew jeffchew mentioned this pull request Feb 1, 2021
Closed
IgnacioBecerra added a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@IgnacioBecerra
fix(language-selector): added clear label attribute (carbon-design-sy…
98b9084 
…stem#4914)

### Related Ticket(s)
carbon-design-system#4889

### Description

The component now has the role of `edit combo` to ensure the screen readers convey its purpose to the users. The clear button also lacked a label to convey functionality upon click/enter. 

### Changelog

**New**

- added clear button label property

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@kennylam kennylam Awaiting requested review from kennylam

@jeffchew jeffchew Awaiting requested review from jeffchew

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

@annawen1 annawen1 Awaiting requested review from annawen1

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IgnacioBecerra @ibmdotcom-bot @asudoh @jeffchew