Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(github-workflow): update test environments with profile host env variable #4912

Merged
merged 4 commits into from
Jan 15, 2021
Merged

chore(github-workflow): update test environments with profile host env variable #4912

merged 4 commits into from
Jan 15, 2021

Conversation

annawen1
Copy link
Member

Related Ticket(s)

Change profile endpoint on Carbon Masthead for signed in state #4701

Description

Add the PROFILE_HOST env variable for our canary and staging storybook environments

Changelog

New

  • {{new thing}}

Changed

  • {{changed thing}}

Removed

  • {{removed thing}}

@annawen1 annawen1 requested a review from jeffchew January 15, 2021 16:37
jeffchew
jeffchew approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 15, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 15, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4912/index.html

Built with commit: 5c6b9250b657c24cdfe0b416a498356fcde11203

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 15, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4912/index.html

Built with commit: 5c6b9250b657c24cdfe0b416a498356fcde11203

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 15, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4912/index.html

Built with commit: 5c6b9250b657c24cdfe0b416a498356fcde11203

@jeffchew jeffchew added Ready to merge Label for the pull requests that are ready to merge and removed Ready to merge Label for the pull requests that are ready to merge labels Jan 15, 2021
@ariellalgilmore ariellalgilmore removed the Ready to merge Label for the pull requests that are ready to merge label Jan 15, 2021
@ariellalgilmore ariellalgilmore merged commit 6e43991 into carbon-design-system:master Jan 15, 2021
@annawen1 annawen1 deleted the chore/github-workflow-profile branch February 10, 2021 18:19
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@annawen1 @kodiakhq @IgnacioBecerra
chore(github-workflow): update test env with profile host var (carbon…
9ac7c98 
…-design-system#4912)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annawen1 @ibmdotcom-bot @jeffchew @ariellalgilmore