Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead-top-nav-menu-item): removing the dark background #4911

Merged
merged 3 commits into from
Jan 15, 2021
Merged

fix(masthead-top-nav-menu-item): removing the dark background #4911

merged 3 commits into from
Jan 15, 2021

Conversation

guilhermelMoraes
Copy link
Contributor

Related Ticket(s)

Web component: Masthead - On hover over the menu options, background color is black #4734

Description

Removing the dark background from dds-top-nav-menu-item

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 15, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4911/index.html

Built with commit: 5522c2dd888e89b2c0491d6647a590aa5010f584

asudoh
asudoh reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guilhermelMoraes I guess you didn't want 910 file changes... Probably you meant different target branch?

@guilhermelMoraes guilhermelMoraes changed the base branch from release/v1.14.0 to master January 15, 2021 15:36
@guilhermelMoraes
Copy link
Contributor Author

@asudoh thanks for noticing! 😅 Just updated the base branch.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 15, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4911/index.html

Built with commit: 5522c2dd888e89b2c0491d6647a590aa5010f584

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 15, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4911/index.html

Built with commit: 5522c2dd888e89b2c0491d6647a590aa5010f584

ariellalgilmore
ariellalgilmore approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @guilhermelMoraes!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Jan 15, 2021
asudoh
asudoh reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guilhermelMoraes for the update. The root cause seems to be https://github.com/carbon-design-system/carbon-for-ibm-dotcom/blob/v1.13.0/packages/styles/scss/components/masthead/_masthead.scss#L125 getting overriden by Carbon core style. Would you try adding [role='menuitem'] to the selector at https://github.com/carbon-design-system/carbon-for-ibm-dotcom/blob/de880d5/packages/styles/scss/components/masthead/_masthead.scss#L282?

@kodiakhq kodiakhq bot merged commit ad6835e into carbon-design-system:master Jan 15, 2021
@guilhermelMoraes guilhermelMoraes deleted the fix/masthead-menu-item-background-color branch January 15, 2021 18:39
@jeffchew jeffchew mentioned this pull request Jan 19, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@guilhermelMoraes @IgnacioBecerra
fix(masthead-top-nav-menu-item): removing the dark background (carbon…
b7df1ba 
…-design-system#4911)

### Related Ticket(s)

Web component: Masthead - On hover over the menu options, background color is black carbon-design-system#4734

### Description

Removing the dark background from `dds-top-nav-menu-item`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh left review comments

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@raphaelamadeu-zz raphaelamadeu-zz Awaiting requested review from raphaelamadeu-zz

@annawen1 annawen1 Awaiting requested review from annawen1

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guilhermelMoraes @ibmdotcom-bot @asudoh @ariellalgilmore