Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(leadspace): reorganize slots #4898

Merged
merged 3 commits into from
Jan 14, 2021
Merged

refactor(leadspace): reorganize slots #4898

merged 3 commits into from
Jan 14, 2021

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 14, 2021

Related Ticket(s)

Refs #4627.

Description

Changes <slot name="buttons"> to <slot name="action"> to align the naming strategy to <dds-cta-section>.

Changelog

Changed

  • Changes <slot name="buttons"> to <slot name="action">.

@asudoh
refactor(leadspace): reorganize slots
35a7b41 
Changes `<slot name="buttons">` to `<slot name="action">` to align the
naming strategy to `<dds-cta-section>`.

Refs carbon-design-system#4627.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Jan 14, 2021
@asudoh asudoh requested a review from annawen1 January 14, 2021 11:42
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 14, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4898/index.html

Built with commit: d9f6e24d1873af3774915a1aa6950868a781817c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 14, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4898/index.html

Built with commit: 870095b65e5bba43c011c7d4fd339d7f5835b0d7

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 14, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4898/index.html

Built with commit: 870095b65e5bba43c011c7d4fd339d7f5835b0d7

@jeffchew
Copy link
Member

@asudoh can you add a note to breaking changes in our pinned issue?

@asudoh asudoh mentioned this pull request Jan 14, 2021
Closed
@asudoh
Copy link
Contributor Author

asudoh commented Jan 14, 2021

@jeffchew Done!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 14, 2021
@kodiakhq kodiakhq bot merged commit f82efba into carbon-design-system:master Jan 14, 2021
@asudoh asudoh deleted the leadspace-slots branch January 15, 2021 00:14
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@asudoh @IgnacioBecerra
refactor(leadspace): reorganize slots (carbon-design-system#4898)
94c7628 
### Related Ticket(s)

Refs carbon-design-system#4627.

### Description

Changes `<slot name="buttons">` to `<slot name="action">` to align the naming strategy to `<dds-cta-section>`.

### Changelog

**Changed**

- Changes `<slot name="buttons">` to `<slot name="action">`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asudoh @ibmdotcom-bot @jeffchew @annawen1