Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(link-list): clean-up CSS classes #4885

Merged
merged 5 commits into from
Jan 14, 2021
Merged

chore(link-list): clean-up CSS classes #4885

merged 5 commits into from
Jan 14, 2021

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Jan 13, 2021

Related Ticket(s)

Refs #4863.

Description

Removes support for bx--link-list__split class in <dds-link-list> and bx--link-list-item__end class in <dds-link-list-item>, for the sake of type attribute in <dds-link-list>.

Changelog

Removed

  • Support for bx--link-list__split class in <dds-link-list>.
  • Support for bx--link-list-item__end class in <dds-link-list-item>.

@asudoh
chore(link-list): clean-up CSS classes
8b573ee 
Removes support for `bx--link-list__split` class in `<dds-link-list>`
and `bx--link-list-item__end` class in `<dds-link-list-item>`, for the
sake of `type` attribute in `<dds-link-list>`.

Refs carbon-design-system#4863.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Jan 13, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 13, 2021 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4885/index.html

Built with commit: 90caf1d8040012ee0f5823a5078d10a93d448bc8

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 13, 2021 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4885/index.html

Built with commit: 90caf1d8040012ee0f5823a5078d10a93d448bc8

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 13, 2021 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4885/index.html

Built with commit: 90caf1d8040012ee0f5823a5078d10a93d448bc8

kennylam
kennylam approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @asudoh!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 13, 2021
@kodiakhq kodiakhq bot removed the Ready to merge Label for the pull requests that are ready to merge label Jan 13, 2021
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jan 13, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the Ready to merge label.

@asudoh asudoh added the Ready to merge Label for the pull requests that are ready to merge label Jan 14, 2021
@asudoh asudoh merged commit 04b4ca7 into carbon-design-system:master Jan 14, 2021
@asudoh asudoh deleted the link-list-classes branch January 14, 2021 04:01
@jeffchew jeffchew mentioned this pull request Jan 19, 2021
Closed
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
@asudoh @IgnacioBecerra
chore(link-list): clean-up CSS classes (carbon-design-system#4885)
783fca2 
Removes support for `bx--link-list__split` class in `<dds-link-list>`
and `bx--link-list-item__end` class in `<dds-link-list-item>`, for the
sake of `type` attribute in `<dds-link-list>`.

Refs carbon-design-system#4863.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@raphaelamadeu-zz raphaelamadeu-zz Awaiting requested review from raphaelamadeu-zz

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asudoh @ibmdotcom-bot @kennylam