Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): add react alt logo story #4878

Merged
merged 2 commits into from
Jan 13, 2021
Merged

chore(storybook): add react alt logo story #4878

merged 2 commits into from
Jan 13, 2021

Conversation

kennylam
Copy link
Member

Related Ticket(s)

#3908

Description

Add alternate logo and tooltip story to React Masthead.

Changelog

New

  • alternate logo and tooltip Masthead story

@kennylam kennylam added the package: react Work necessary for the Carbon for IBM.com react components package label Jan 12, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2021

Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @kennylam!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 13, 2021
@kodiakhq kodiakhq bot merged commit a321c35 into carbon-design-system:master Jan 13, 2021
@kennylam kennylam deleted the chore/react-masthead-alt-logo branch January 13, 2021 23:00
IgnacioBecerra pushed a commit to IgnacioBecerra/ibm-dotcom-library that referenced this pull request Feb 22, 2021
### Related Ticket(s)

carbon-design-system#3908 

### Description

Add alternate logo and tooltip story to React `Masthead`.

### Changelog

**New**

- alternate logo and tooltip `Masthead` story

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "package: styles": Carbon Expressive -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants