Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ContentGroupSimple): fix stories card cta knobs #4853

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#4609

Description

Fix Content Group Simple card cta story, so that knobs change card to local, jump, external, download, etc...

Changelog

Changed

  • stories to adjustable parameters

@ariellalgilmore ariellalgilmore added the package: web components Work necessary for the IBM.com Library web components package label Jan 8, 2021
@ariellalgilmore ariellalgilmore changed the title Fix/content group simple stories fix(ContentGroupSimple): fix stories card cta knobs Jan 8, 2021
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 8, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 8, 2021

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 8, 2021

Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Jan 8, 2021
@kodiakhq kodiakhq bot merged commit 0b7cdbe into carbon-design-system:master Jan 8, 2021
@ariellalgilmore ariellalgilmore deleted the fix/content-group-simple_stories branch January 8, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants