Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(percy): suppressing callout media video player in percy #4788

Merged
merged 2 commits into from
Dec 30, 2020
Merged

chore(percy): suppressing callout media video player in percy #4788

merged 2 commits into from
Dec 30, 2020

Conversation

jeffchew
Copy link
Member

Related Ticket(s)

No related issue

Description

This suppresses the callout media with video in percy, which is causing false positives in visual regression tests.

Changelog

Changed

  • hide dds-callout-with-media-video in percy/browserstack

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 29, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4788/index.html

Built with commit: 8afde271eee2c6719576152ed0ea087a0163956d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 29, 2020 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4788/index.html

Built with commit: 8afde271eee2c6719576152ed0ea087a0163956d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 29, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4788/index.html

Built with commit: 8afde271eee2c6719576152ed0ea087a0163956d

asudoh
asudoh approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @jeffchew!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Dec 30, 2020
@kodiakhq kodiakhq bot merged commit 0e74853 into carbon-design-system:master Dec 30, 2020
@jeffchew jeffchew mentioned this pull request Jan 11, 2021
Closed
@jeffchew jeffchew deleted the chore/percy branch February 8, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffchew @ibmdotcom-bot @asudoh