Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dotcom-shell): removing min-height from dotcom-shell #4786

Merged
merged 1 commit into from
Dec 29, 2020
Merged

fix(dotcom-shell): removing min-height from dotcom-shell #4786

merged 1 commit into from
Dec 29, 2020

Conversation

guilhermelMoraes
Copy link
Contributor

Description

This min-height: 100vh property was causing the /build page to be taller than it should.

Screen Shot 2020-12-29 at 12 24 59

@guilhermelMoraes guilhermelMoraes added the package: web components Work necessary for the IBM.com Library web components package label Dec 29, 2020
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4786/index.html

Built with commit: a66108b4730569493788f4fad5e8e42bc01d59a0

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4786/index.html

Built with commit: a66108b4730569493788f4fad5e8e42bc01d59a0

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4786/index.html

Built with commit: a66108b4730569493788f4fad5e8e42bc01d59a0

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Dec 29, 2020
@kodiakhq kodiakhq bot merged commit cbcb9a2 into carbon-design-system:master Dec 29, 2020
@guilhermelMoraes guilhermelMoraes deleted the fix/dotcom-shell-height branch December 29, 2020 18:10
@jeffchew jeffchew mentioned this pull request Jan 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermelMoraes @ibmdotcom-bot @jeffchew