Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(footer): language only for web component variations #4772

Merged
merged 22 commits into from
Jan 8, 2021
Merged

feat(footer): language only for web component variations #4772

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3d81568
temp commit
IgnacioBecerra Dec 23, 2020
5eca34f
feat(footer): language only selector introduced
IgnacioBecerra Jan 6, 2021
c2363bf
Merge branch 'master' into footer-language-only
IgnacioBecerra Jan 6, 2021
4c580d7
feat(footer): added fixes
IgnacioBecerra Jan 6, 2021
2c3b990
feat(footer): ran prettier
IgnacioBecerra Jan 6, 2021
6810126
feat(footer): addressed comments and updated snapshots
IgnacioBecerra Jan 7, 2021
83e5b2e
feat(footer): using property binding to deserialize list
IgnacioBecerra Jan 8, 2021
9c607a4
feat(language-selector): addressed more comments
IgnacioBecerra Jan 8, 2021
d835127
feat(footer): updated to conform to coding guidelines
IgnacioBecerra Jan 8, 2021
058d5fb
feat(foot): removed callback
IgnacioBecerra Jan 8, 2021
4f7b782
feat(footer): updated snapshots
IgnacioBecerra Jan 8, 2021
0391e72
feat(footer): addressed feedback
IgnacioBecerra Jan 8, 2021
f3a8186
feat(footer): removed enableSelector
IgnacioBecerra Jan 8, 2021
d7e678e
feat(footer): reorganized code
IgnacioBecerra Jan 8, 2021
c77c436
feat(footer): replaced updated with super call
IgnacioBecerra Jan 8, 2021
a797ad5
Merge branch 'master' into footer-language-only
asudoh Jan 8, 2021
aa982e7
chore(footer): added documentation
IgnacioBecerra Jan 8, 2021
3294e29
Merge branch 'master' into footer-language-only
IgnacioBecerra Jan 8, 2021
8642b95
chore(footer): updated readme
IgnacioBecerra Jan 8, 2021
0679e46
Merge branch 'master' into footer-language-only
IgnacioBecerra Jan 8, 2021
e2fe580
Merge branch 'master' into footer-language-only
kodiakhq[bot] Jan 8, 2021
ea5db15
Merge branch 'master' into footer-language-only
kodiakhq[bot] Jan 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/web-components/src/components/footer/__stories__/footer.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const base = ({ parameters }) => {
language="${ifNonNull(language)}"
lang-display="${ifNonNull(langDisplay)}"
size="${ifNonNull(size)}"
lang-list="${ifNonNull(langList)}"
.langList="${ifNonNull(langList)}"
.legalLinks="${ifNonNull(legalLinks)}"
.links="${ifNonNull(links)}"
.localeList="${ifNonNull(localeList)}"
Expand All @@ -60,7 +60,7 @@ export const base = ({ parameters }) => {
language="${ifNonNull(language)}"
lang-display="${ifNonNull(langDisplay)}"
size="${ifNonNull(size)}"
lang-list="${ifNonNull(JSON.stringify(langList))}"
.langList="${ifNonNull(langList)}"
.legalLinks="${ifNonNull(legalLinks)}"
.links="${ifNonNull(links)}"
.localeList="${ifNonNull(localeList)}"
Expand Down
9 changes: 3 additions & 6 deletions packages/web-components/src/components/footer/footer-composite.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ class DDSFooterComposite extends ModalRenderMixin(HybridRenderMixin(HostListener
*
* @internal
*/
@property({ attribute: 'lang-list' })
langList?: string;
@property({ attribute: false })
langList?: any[];

/**
* The language to show in the UI.
Expand Down Expand Up @@ -248,9 +248,6 @@ class DDSFooterComposite extends ModalRenderMixin(HybridRenderMixin(HostListener
_handleClickLocaleButton: handleClickLocaleButton,
_languageCallback: languageCallback,
} = this;

const parsedList = !langList ? undefined : JSON.parse(langList as string);

return html`
<dds-footer size="${ifNonNull(size)}">
<dds-footer-logo></dds-footer-logo>
Expand Down Expand Up @@ -279,7 +276,7 @@ class DDSFooterComposite extends ModalRenderMixin(HybridRenderMixin(HostListener
value="${selectedLanguage}"
@bx-combo-box-selected="${languageCallback}"
>
${parsedList?.map(
${langList?.map(
IgnacioBecerra marked this conversation as resolved.
Show resolved Hide resolved
({ text: language }) => html`
<bx-combo-box-item value="${ifNonNull(language)}">${ifNonNull(language)}</bx-combo-box-item>
`
Expand Down