style(leadspace): added explicit height declaration for sections #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview created for package Built with commit: f179fc91b55cb0ac965afb50c4ebf1f67d69c92a |
|
Deploy preview created for package Built with commit: f179fc91b55cb0ac965afb50c4ebf1f67d69c92a |
|
Deploy preview created for package Built with commit: f179fc91b55cb0ac965afb50c4ebf1f67d69c92a |
asudoh
approved these changes
Dec 22, 2020
asudoh
added
package: react
guilhermelMoraes
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the
::partpseudo-element introduction (#4752) to change the leadspace height according to the Partner world landing page requirements, I've missed adding an explicitheight: 100%declaration for the wrappers below it. This is causing the leadspace to be visually broken for themdandsmbreakpoints.