Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feature-card): ensure aligned to grid line #4751

Merged
merged 8 commits into from
Dec 23, 2020
Merged

fix(feature-card): ensure aligned to grid line #4751

merged 8 commits into from
Dec 23, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Dec 18, 2020

Related Ticket(s)

Refs #4174.

Description

Changes style of feature card to ensure it's aligned to grid line without gutter.

The style of feature card used to have adjustments (e.g. by negative margin) to adjust for its surrounding grid gutter, which is removed with this change.

Changelog

New

  • Simplified Carbon grid style for stories.

Changed

  • Fixed feature card to ensure it's aligned to grid line (without gutter).

Removed

  • Style adjustments in feature card (e.g. by negative margin) to adjust for its surrounding grid gutter.

@asudoh
fix(feature-card): ensure aligned to grid line
e7c017c 
Changes style of feature card to ensure it's aligned to grid line
without gutter.

The style of feature card used to have adjustments (e.g. by negative
margin) to adjust for its surrounding grid gutter, which is removed
with this change.

Refs carbon-design-system#4174.
@asudoh
test(feature-card): update snapshot
c26bd08
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 18, 2020 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4751/index.html

Built with commit: 428d49594c3a1bb84257c38a95f8955eb847592e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 18, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4751/index.html

Built with commit: 428d49594c3a1bb84257c38a95f8955eb847592e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 18, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4751/index.html

Built with commit: 428d49594c3a1bb84257c38a95f8955eb847592e

@asudoh
Copy link
Contributor Author

asudoh commented Dec 18, 2020

@guilhermelMoraes Fixed the regression in React.

@asudoh asudoh added package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package labels Dec 22, 2020
jeffchew
jeffchew approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @asudoh !

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Dec 22, 2020
@kodiakhq kodiakhq bot merged commit 072e68f into carbon-design-system:master Dec 23, 2020
@jeffchew jeffchew mentioned this pull request Dec 29, 2020
Closed
@asudoh asudoh deleted the card-grid-alt branch January 5, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@guilhermelMoraes guilhermelMoraes Awaiting requested review from guilhermelMoraes

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asudoh @ibmdotcom-bot @jeffchew @guilhermelMoraes