Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(masthead): add horizontal scroller #4717

Merged
merged 7 commits into from
Dec 29, 2020
Merged

feat(masthead): add horizontal scroller #4717

merged 7 commits into from
Dec 29, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Dec 11, 2020 •
edited
Loading

Related Ticket(s)

Refs #4457.

Description

TBD

Changelog

New

  • The horizontal scroller in <dds-top-nav>.

Changed

  • The breakpoint of left/top nav switch (from md to 800px).

@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Dec 11, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 11, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4717/index.html

Built with commit: db58d6b34e09c4c198bd57794e3dac5d9bd8b900

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 11, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4717/index.html

Built with commit: db58d6b34e09c4c198bd57794e3dac5d9bd8b900

@asudoh asudoh force-pushed the masthead-scroller branch 2 times, most recently from 5a46b01 to d7bd30a Compare December 15, 2020 03:08
@asudoh asudoh marked this pull request as ready for review December 15, 2020 05:14
kennylam
kennylam reviewed Dec 15, 2020
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asudoh Small thing it looks like the L0 is appearing behind the profile button because it has no background color set. Giving dds-masthead-profile a background color of white should fix.

image

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 16, 2020 •
edited
Loading

Deploy preview created for package Web Components - React Wrapper:
https://ibmdotcom-web-components-react.ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4717/index.html

Built with commit: db58d6b34e09c4c198bd57794e3dac5d9bd8b900

@asudoh
Copy link
Contributor Author

asudoh commented Dec 17, 2020

Good catch @kennylam! - Updated.

jeffchew
jeffchew approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @asudoh , looks good!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Dec 29, 2020
@kodiakhq kodiakhq bot merged commit 6d6bd55 into carbon-design-system:master Dec 29, 2020
@jeffchew jeffchew mentioned this pull request Jan 11, 2021
Closed
@asudoh asudoh deleted the masthead-scroller branch February 24, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam left review comments

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asudoh @ibmdotcom-bot @kennylam @jeffchew