Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pictogram-item): added prop table and data-autoid #4666

Merged
merged 4 commits into from
Dec 8, 2020
Merged

fix(pictogram-item): added prop table and data-autoid #4666

merged 4 commits into from
Dec 8, 2020

Conversation

raphaelamadeu-zz
Copy link
Contributor

Related Ticket(s)

#4367

Description

Added data-auto id to dds-pictogram-item and added prop table to it's documentation.

Changelog

New

  • Added data-autoid
  • Added prop table

@raphaelamadeu-zz raphaelamadeu-zz added the package: web components Work necessary for the IBM.com Library web components package label Dec 8, 2020
asudoh
asudoh approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @raphaelamadeu!

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 8, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4666/index.html

Built with commit: 0279d0e14365018cf355181f93887155e571352d

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 8, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4666/index.html

Built with commit: 0279d0e14365018cf355181f93887155e571352d

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Dec 8, 2020
@kodiakhq kodiakhq bot merged commit 08c02fc into carbon-design-system:master Dec 8, 2020
@jeffchew jeffchew mentioned this pull request Dec 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@kennylam kennylam Awaiting requested review from kennylam

@jeffchew jeffchew Awaiting requested review from jeffchew

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raphaelamadeu-zz @ibmdotcom-bot @asudoh @jeffchew