Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(link-list): add missing mixin #4632

Merged
merged 2 commits into from
Dec 7, 2020
Merged

fix(link-list): add missing mixin #4632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc1a52e
fix(link-list): add missing mixin
asudoh Dec 7, 2020
a84cab1
docs(link-list): unify the format
asudoh Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions packages/web-components/src/components/link-list/__stories__/README.stories.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,20 @@ import '@carbon/ibmdotcom-web-components/es/components/card-link/card-link.js';

```html
<dds-link-list>
<dds-link-list-item>

</dds-link-list-item>
<dds-link-list-item></dds-link-list-item>
<dds-card-link href="https://example.com">
<p>Copy text</p>
<svg slot="footer" focusable="false" preserveAspectRatio="xMidYMid meet" xmlns="http://www.w3.org/2000/svg" fill="currentColor" aria-hidden="true" width="20" height="20" viewBox="0 0 20 20">
<svg
slot="footer"
focusable="false"
preserveAspectRatio="xMidYMid meet"
xmlns="http://www.w3.org/2000/svg"
fill="currentColor"
aria-hidden="true"
width="20"
height="20"
viewBox="0 0 20 20"
>
<path d="M11.8 2.8L10.8 3.8 16.2 9.3 1 9.3 1 10.7 16.2 10.7 10.8 16.2 11.8 17.2 19 10z"></path>
</svg>
</dds-card-link>
Expand All @@ -42,4 +50,12 @@ import '@carbon/ibmdotcom-web-components/es/components/card-link/card-link.js';

<Props of="dds-link-list" />

## Stable selectors

See [our README](https://github.com/carbon-design-system/carbon-for-ibm-dotcom/tree/master/packages/web-components#stable-selectors-for-analytics-and-integratione2e-testing-in-web-components) to see how Web Components selector and `data-autoid` should be used.

| Web Components selector | Compatibility selector | Description |
| ----------------------- | ---------------------------- | ----------- |
| `<dds-link-list>` | data-autoid="dds--link-list" | Component |

<Description markdown={contributing} />
3 changes: 2 additions & 1 deletion packages/web-components/src/components/link-list/link-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { customElement, html, LitElement, property } from 'lit-element';
import settings from 'carbon-components/es/globals/js/settings';
import ddsSettings from '@carbon/ibmdotcom-utilities/es/utilities/settings/settings';
import sameHeight from '@carbon/ibmdotcom-utilities/es/utilities/sameHeight/sameHeight';
import StableSelectorMixin from '../../globals/mixins/stable-selector';
import styles from './link-list.scss';

const { prefix } = settings;
Expand Down Expand Up @@ -47,7 +48,7 @@ export enum LINK_LIST_TYPE {
* @slot heading - The heading content.
*/
@customElement(`${ddsPrefix}-link-list`)
class DDSLinkList extends LitElement {
class DDSLinkList extends StableSelectorMixin(LitElement) {
static styles = styles; // `styles` here is a `CSSResult` generated by custom WebPack loader

private childItems;
Expand Down