Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead): add aria-hidden to overflow nav carets #4489

Merged
merged 4 commits into from
Nov 13, 2020
Merged

fix(masthead): add aria-hidden to overflow nav carets #4489

merged 4 commits into from
Nov 13, 2020

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#4182

Description

add aria-hidden to caret buttons for screen readers using up and down arrows

Changelog

New

  • add aria-hidden="true" to carets

@ariellalgilmore ariellalgilmore added the package: react Work necessary for the Carbon for IBM.com react components package label Nov 13, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 13, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4489/index.html

Built with commit: eebb2efe0916396aa692f29bea44abbec06fa436

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 13, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4489/index.html

Built with commit: eebb2efe0916396aa692f29bea44abbec06fa436

annawen1
annawen1 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Ari!

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Nov 13, 2020
@kodiakhq kodiakhq bot merged commit c44b6a5 into carbon-design-system:master Nov 13, 2020
@ariellalgilmore ariellalgilmore deleted the fix/overflow-nav branch November 13, 2020 18:51
@jeffchew jeffchew mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@raphaelamadeu-zz raphaelamadeu-zz Awaiting requested review from raphaelamadeu-zz

@andysherman2121 andysherman2121 Awaiting requested review from andysherman2121

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra

@jeffchew jeffchew Awaiting requested review from jeffchew

@kennylam kennylam Awaiting requested review from kennylam

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariellalgilmore @ibmdotcom-bot @annawen1