Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cardgroup): update sameheight selectors #4484

Merged
merged 7 commits into from
Nov 13, 2020
Merged

fix(cardgroup): update sameheight selectors #4484

merged 7 commits into from
Nov 13, 2020

Conversation

kennylam
Copy link
Member

Related Ticket(s)

#4311

Description

Fixes an issue where elements were not being targeted by sameHeight.

Changelog

Changed

  • update CSS selectors for sameHeight
  • update card data for Storybook

@kennylam kennylam added the package: react Work necessary for the Carbon for IBM.com react components package label Nov 12, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 12, 2020

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 12, 2020

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @kennylam

@annawen1 annawen1 added the Ready to merge Label for the pull requests that are ready to merge label Nov 13, 2020
@kodiakhq kodiakhq bot merged commit 0a25048 into carbon-design-system:master Nov 13, 2020
@kennylam kennylam deleted the fix/cardgroup-sameheight branch November 13, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants