Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Images): update FPO images url #4482

Merged
merged 5 commits into from
Nov 12, 2020
Merged

fix(Images): update FPO images url #4482

merged 5 commits into from
Nov 12, 2020

Conversation

kennylam
Copy link
Member

Description

Dummyimage, the online image generator used for our FPO images has gone offline. This change updates all images to use fpoimg.

Changelog

Changed

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 12, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4482/index.html

Built with commit: 4088cb42a1fc70381f937823483c217194be3d52

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 12, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4482/index.html

Built with commit: 4088cb42a1fc70381f937823483c217194be3d52

@kennylam kennylam changed the title fix(Images): update FPO url fix(Images): update FPO images url Nov 12, 2020
jeffchew
jeffchew approved these changes Nov 12, 2020
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Nov 12, 2020
@kodiakhq kodiakhq bot merged commit 13b0181 into carbon-design-system:master Nov 12, 2020
@kennylam kennylam deleted the fix/fpo-images branch November 12, 2020 19:54
@jeffchew jeffchew mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennylam @ibmdotcom-bot @jeffchew