Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Masthead): add search custom events #4460

Merged
merged 2 commits into from
Nov 11, 2020
Merged

feat(Masthead): add search custom events #4460

merged 2 commits into from
Nov 11, 2020

Conversation

kennylam
Copy link
Member

Related Ticket(s)

#4398

Description

Adds several custom events to masthead search.

Changelog

New

  • adds onOpenSearch, onSearchCloseClicked, onSearchButtonClicked, onSearchValueChanged custom events to masthead search
  • add custom event documentation

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 11, 2020

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 11, 2020

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kennylam!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Nov 11, 2020
@kodiakhq kodiakhq bot merged commit a4abe4f into carbon-design-system:master Nov 11, 2020
@kennylam kennylam deleted the feat/masthead-search-custom-events branch November 23, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants