feat(content-group-horizontal): create web component #4435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariellalgilmore
added
package: web components
|
Deploy preview created for package Built with commit: bf39f3e657ed49955cbf57ef299f3fb122ee0958 |
|
Deploy preview created for package Built with commit: bf39f3e657ed49955cbf57ef299f3fb122ee0958 |
asudoh
reviewed
Nov 10, 2020
packages/web-components/examples/codesandbox/components/content-group-horizontal/index.html
Outdated
Show resolved
Hide resolved
packages/web-components/examples/codesandbox/components/content-group-horizontal/index.html
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-group-horizontal/__stories__/README.stories.mdx
Outdated
Show resolved
Hide resolved
...ents/src/components/content-group-horizontal/__stories__/content-group-horizontal.stories.ts
Outdated
Show resolved
Hide resolved
...omponents/src/components/content-group-horizontal/__tests__/content-group-horizontal.test.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-group-horizontal/__stories__/README.stories.mdx
Outdated
Show resolved
Hide resolved
...ents/src/components/content-group-horizontal/__stories__/content-group-horizontal.stories.ts
Outdated
Show resolved
Hide resolved
...omponents/src/components/content-group-horizontal/__tests__/content-group-horizontal.test.ts
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/content-group-horizontal/__stories__/README.stories.mdx
Show resolved
Hide resolved
…t-group-horizontal/index.html Co-authored-by: Akira Sudoh <[email protected]>
…l/__stories__/README.stories.mdx Co-authored-by: Akira Sudoh <[email protected]>
…l/__stories__/content-group-horizontal.stories.ts Co-authored-by: Akira Sudoh <[email protected]>
…l/__tests__/content-group-horizontal.test.ts Co-authored-by: Akira Sudoh <[email protected]>
…l/__stories__/README.stories.mdx Co-authored-by: Akira Sudoh <[email protected]>
asudoh
reviewed
Nov 11, 2020
| @@ -37,7 +37,7 @@ | |||
| } | |||
|
|
|||
| :host(#{$dds-prefix}-content-item-horizontal) ::slotted([slot='heading']), | |||
| :host(#{$dds-prefix}-content-item-horizontal) .#{$prefix}--content-item__copy, | |||
| :host(#{$dds-prefix}-content-item-horizontal) ::slotted([slot='copy']), | |||
There was a problem hiding this comment.
Probably we can keep using the default slot for copy content in this way...?
Suggested change
| :host(#{$dds-prefix}-content-item-horizontal) ::slotted([slot='copy']), | |
| :host(#{$dds-prefix}-content-item-horizontal) ::slotted(:not([slot])), |
asudoh
approved these changes
Nov 11, 2020
asudoh
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
#3796
Description
create content-group-horizontal web component
Changelog
New
Changed