Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(masthead): remove console errors #4404

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#4403

Description

remove console errors from overflow navigation work

Changelog

New

  • checks if components exist before calling function

@ariellalgilmore ariellalgilmore added the package: react Work necessary for the Carbon for IBM.com react components package label Nov 4, 2020
@ibmdotcom-bot
Copy link
Contributor

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @ariellalgilmore!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Nov 4, 2020
@ibmdotcom-bot
Copy link
Contributor

@kodiakhq kodiakhq bot merged commit 5756618 into carbon-design-system:master Nov 4, 2020
@ariellalgilmore ariellalgilmore deleted the fix/masthead-console-errors branch November 4, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants