fix(image-with-caption): a11y fixes #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asudoh
added
the
package: web components
Fixes `alt` attribute of `<dds-image-with-caption>` not being propagated to `<dds-image>` in non-lightbox mode. Also: * Introduces `launch-lightbox-button-assistive-text` attribute as the assistive text for the launcher button of the lightbox. * Adds a change to ensure `undefined`/`null` property values won't be set to `<dds-image>`, etc. Refs carbon-design-system#4265.
asudoh
force-pushed
the
image-with-caption-a11y-fixes
branch
from
0959121 to
7a10725
Compare
|
Deploy preview created for package Built with commit: 46f9d0323e02b870f2836a7d66178e4ddd5b20de |
|
Deploy preview created for package Built with commit: 46f9d0323e02b870f2836a7d66178e4ddd5b20de |
jeffchew
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Refs #4265.
Description
Fixes
altattribute of<dds-image-with-caption>not being propagated to<dds-image>in non-lightbox mode.Also:
launch-lightbox-button-assistive-textattribute as the assistive text for the launcher button of the lightbox.undefined/nullproperty values won't be set to<dds-image>, etc.Changelog
New
launch-lightbox-button-assistive-textattribute as the assistive text for the launcher button of the lightbox.Changed
altattribute of<dds-image-with-caption>`` not being propagated to` in non-lightbox mode.undefined/nullproperty values won't be set to<dds-image>, etc.