Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button-group): eliminate duplicate outline #4350

Merged
merged 1 commit into from
Oct 29, 2020
Merged

fix(button-group): eliminate duplicate outline #4350

merged 1 commit into from
Oct 29, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Oct 29, 2020

Related Ticket(s)

Refs #4348.

Description

Fixes duplicate focus outline in <dds-button-group-item>, that made the focus outline too thick. Also given the earlier workaround for such duplicate focus outline issue is no longer needed, removed it.

Changelog

Removed

  • The redundant focus outline on <dds-button-group-item>
  • The earlier workaround for above issue.

@asudoh
fix(button-group): eliminate duplicate outline
c6df943 
Fixes duplicate focus outline in `<dds-button-group-item>`, that made
the focus outline too thick. Also given the earlier workaround for such
duplicate focus outline issue is no longer needed, removed it.

Refs carbon-design-system#4348.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Oct 29, 2020
@asudoh asudoh requested a review from IgnacioBecerra October 29, 2020 22:37
@asudoh asudoh mentioned this pull request Oct 29, 2020
Merged
IgnacioBecerra
IgnacioBecerra approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment on my PR, Akira! I see how delegateFocus was affecting the outline now, LGTM!

@asudoh asudoh added the Ready to merge Label for the pull requests that are ready to merge label Oct 29, 2020
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4350/index.html

Built with commit: c6df943aaecbbff364a4a6b42a0eb299737cc2e3

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4350/index.html

Built with commit: c6df943aaecbbff364a4a6b42a0eb299737cc2e3

@kodiakhq kodiakhq bot merged commit 80aa479 into carbon-design-system:master Oct 29, 2020
@asudoh asudoh deleted the buttongroup-delegatesfocus branch October 29, 2020 23:13
@jeffchew jeffchew mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asudoh @ibmdotcom-bot @IgnacioBecerra