Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-selector): update language selector to use select #4335

Merged
merged 6 commits into from
Oct 29, 2020
Merged

fix(language-selector): update language selector to use select #4335

merged 6 commits into from
Oct 29, 2020

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Oct 28, 2020 •
edited
Loading

Related Ticket(s)

#4330, #4331

Description

This change adds Carbon's Select component for the footer language selector in mobile/tablet breakpoints. Desktop views will continue to use ComboBox.

Changelog

Changed

  • Footer language selector now uses Carbon's Select instead of ComboBox for mobile/tablet breakpoints
  • updated various styles for new component

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 28, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4335/index.html

Built with commit: d75f8d79304968452af48086e9085702bafbd6bf

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 28, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4335/index.html

Built with commit: d75f8d79304968452af48086e9085702bafbd6bf

This was referenced Oct 28, 2020
Closed
Closed
@Praveen-sr
Copy link

@kennylam Re tested on the new PR link, above issue is fixed, Working fine now.

But new issue is found,
Issue: There is no label for this dropdown

Expected: Provide label for the dropdown using html label tag or aria label

jeffchew
jeffchew approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Looks like Praveen has some feedback.

raphaelamadeu-zz
raphaelamadeu-zz approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@raphaelamadeu-zz raphaelamadeu-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Oct 29, 2020
@kodiakhq kodiakhq bot merged commit 4d19fa8 into carbon-design-system:master Oct 29, 2020
@kennylam kennylam deleted the fix/footer-language-combo-to-select branch October 29, 2020 20:45
@jeffchew jeffchew mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelamadeu-zz raphaelamadeu-zz raphaelamadeu-zz approved these changes

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennylam @ibmdotcom-bot @Praveen-sr @jeffchew @raphaelamadeu-zz