Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(overflow): add animation and update snapshots #4305

Merged
merged 2 commits into from
Oct 26, 2020
Merged

feat(overflow): add animation and update snapshots #4305

merged 2 commits into from
Oct 26, 2020

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

#4164

Description

create scrolling animation for overflow
ezgif com-gif-maker

Changelog

New

  • additional styles
  • use intersectionObserver to check for turning on and off left and right carets

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 26, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4305/index.html

Built with commit: ca886c390b68e3b258406f2709ac73a1c08f7c39

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 26, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4305/index.html

Built with commit: ca886c390b68e3b258406f2709ac73a1c08f7c39

@ariellalgilmore ariellalgilmore added package: react Work necessary for the Carbon for IBM.com react components package hacktoberfest labels Oct 26, 2020
asudoh
asudoh approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🎉 - Thanks @ariellalgilmore!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Oct 26, 2020
@kodiakhq kodiakhq bot merged commit 4019ee0 into carbon-design-system:master Oct 26, 2020
@ariellalgilmore ariellalgilmore deleted the feat/overflow-animation branch October 26, 2020 23:36
@jeffchew jeffchew mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@jeffchew jeffchew Awaiting requested review from jeffchew

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ariellalgilmore @ibmdotcom-bot @asudoh @jeffchew