Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table-of-contents): fix header space #4298

Merged

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Oct 26, 2020

Related Ticket(s)

Refs #4262.

Description

This change ensures the area for the heading content is hidden unless there is its content actually.

Changelog

New

  • UI integration test for below change.

Changed

  • A change to ensure the area for the heading content is hidden unless there is its content actually.

This change ensures the area for the heading content is hidden unless
there is its content actually.

Refs carbon-design-system#4262.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Oct 26, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 26, 2020

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 26, 2020

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @asudoh!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Oct 28, 2020
@kodiakhq kodiakhq bot merged commit 10d7de0 into carbon-design-system:master Oct 28, 2020
@asudoh asudoh deleted the table-of-contents-header-space branch October 28, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants