Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(locale-modal): ensure input field is cleared on reset #4296

Merged
merged 3 commits into from
Oct 27, 2020
Merged

fix(locale-modal): ensure input field is cleared on reset #4296

merged 3 commits into from
Oct 27, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Oct 26, 2020

Related Ticket(s)

Refs #4222.

Changelog

Changed

  • A fix is made to ensure input field is cleared on resetting <dds-locale-search>.

@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Oct 26, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 26, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4296/index.html

Built with commit: 6e50035f5b473724cef0eac9bc08dd3ec7ae6bb3

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 26, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4296/index.html

Built with commit: 6e50035f5b473724cef0eac9bc08dd3ec7ae6bb3

jeffchew
jeffchew approved these changes Oct 26, 2020
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Oct 26, 2020
@kodiakhq kodiakhq bot merged commit 737589a into carbon-design-system:master Oct 27, 2020
@asudoh asudoh deleted the locale-modal-reset-search-box branch October 27, 2020 01:25
@jeffchew jeffchew mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asudoh @ibmdotcom-bot @jeffchew