fix(megamenu): added protection to fix layout problem #4290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
photodow
force-pushed
the
megamenu-layout-fix
branch
from
8c272d3 to
43cf7b9
Compare
|
Deploy preview created for package Built with commit: 958d057a2a60d420135af8c3dead1f41e5e5f209 |
photodow
force-pushed
the
megamenu-layout-fix
branch
from
43cf7b9 to
958d057
Compare
|
Deploy preview created for package Built with commit: 958d057a2a60d420135af8c3dead1f41e5e5f209 |
kennylam
approved these changes
Oct 22, 2020
kennylam
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
fixes #4078
Description
What a fickle little layout problem we have here. I saw we were having trouble with this and had an idea of how to fix it. Basically, I threw in one or two wrapping divs to help protect the content, and render consistently across the board. It looks like it's working from my perspective and understanding, but let me know if I missed some consideration here.
Changelog
Changed