fix(footer): ensure IBM logo icon is visible #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the rendering issue of IBM logo icon in footer by fixing wrong `width` and `height` attributes. Also fixes wrong content in the `<title>` attribute in corresponding SVG, by avoiding to bake it in the `lit-html` SVG template for the IBM logo icon. The approach is taken because the `<title>` content is not the design asset, and may have to be translated in future. Due to such reason, omitted some other attributes from the `lit-html` SVG template for the IBM logo icon, too. Refs carbon-design-system#4224.
asudoh
added
the
package: web components
|
Deploy preview created for package Built with commit: ec96cf4b792c58684b21fa7e98d8aebde0eceb61 |
|
Deploy preview created for package Built with commit: ec96cf4b792c58684b21fa7e98d8aebde0eceb61 |
kennylam
approved these changes
Oct 14, 2020
|
@asudoh Looks like the only thing is the snapshot is outdated. |
jeffchew
added
the
Ready to merge
ariellalgilmore
pushed a commit
to ariellalgilmore/carbon-for-ibm-dotcom
that referenced
this pull request
Oct 22, 2020
### Related Ticket(s) Refs carbon-design-system#4224. ### Description Fixes the rendering issue of IBM logo icon in footer by fixing wrong `width` and `height` attributes. Also fixes wrong content in the `<title>` attribute in corresponding SVG, by avoiding to bake it in the `lit-html` SVG template for the IBM logo icon. The approach is taken because the `<title>` content is not the design asset, and may have to be translated in future. Due to such reason, omitted some other attributes from the `lit-html` SVG template for the IBM logo icon, too. ### Changelog **Changed** - Fixes to IBM logo icon: - Add right `width` and `height` attributes - Omit `<title>` and some attributes from `lit-html` SVG template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Refs #4224.
Description
Fixes the rendering issue of IBM logo icon in footer by fixing wrong
widthandheightattributes.Also fixes wrong content in the
<title>attribute in corresponding SVG, by avoiding to bake it in thelit-htmlSVG template for the IBM logo icon. The approach is taken because the<title>content is not the design asset, and may have to be translated in future. Due to such reason, omitted some other attributes from thelit-htmlSVG template for the IBM logo icon, too.Changelog
Changed
widthandheightattributes<title>and some attributes fromlit-htmlSVG template