Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(table-of-contents): support dark theme #4213

Merged
merged 4 commits into from
Oct 16, 2020
Merged

fix(table-of-contents): support dark theme #4213

merged 4 commits into from
Oct 16, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Oct 12, 2020 •
edited
Loading

Refs #4214.

Changelog

Changed

  • Support dark theme in table of contents, both in React and in Web Components.

@asudoh asudoh added package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package labels Oct 12, 2020
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 12, 2020 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4213/index.html

Built with commit: a00e99678172632b44a4545cf98aeb5f1c8f26f1

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 12, 2020 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4213/index.html

Built with commit: a00e99678172632b44a4545cf98aeb5f1c8f26f1

@IgnacioBecerra IgnacioBecerra self-requested a review October 14, 2020 20:41
IgnacioBecerra
IgnacioBecerra approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jeffchew
jeffchew approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew
Copy link
Member

@asudoh I started going through the visual changes, can you confirm some of them look right? There are a lot in the React one.

@asudoh
Copy link
Contributor Author

asudoh commented Oct 16, 2020

Thank you for pointing it out @jeffchew - Fixed.

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Oct 16, 2020
@kodiakhq kodiakhq bot merged commit b123071 into carbon-design-system:master Oct 16, 2020
@asudoh asudoh deleted the toc-dark-theme branch October 16, 2020 23:41
ariellalgilmore pushed a commit to ariellalgilmore/carbon-for-ibm-dotcom that referenced this pull request Oct 22, 2020
@asudoh @ariellalgilmore
fix(table-of-contents): support dark theme (carbon-design-system#4213)
1599e07 
Refs carbon-design-system#4214.

### Changelog

**Changed**

- Support dark theme in table of contents, both in React and in Web Components.
@jeffchew jeffchew mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@jeffchew jeffchew jeffchew approved these changes

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asudoh @ibmdotcom-bot @jeffchew @IgnacioBecerra @kennylam