Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(videoplayer): add closed captions #4036

Merged
merged 1 commit into from
Sep 24, 2020
Merged

feat(videoplayer): add closed captions #4036

merged 1 commit into from
Sep 24, 2020

Conversation

kennylam
Copy link
Member

Related Ticket(s)

#4012

Description

Add closed caption button to VideoPlayer.

Changelog

New

  • closed captioning button to Kaltura video player

@kennylam kennylam added the package: services Work necessary for the Carbon for IBM.com services package label Sep 23, 2020
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4036/index.html

Built with commit: 427438e58bf70cd0065d34c87b047bb7c49daf1b

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/4036/index.html

Built with commit: 427438e58bf70cd0065d34c87b047bb7c49daf1b

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package "Services":
https://ibmdotcom-services.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/4036/index.html

Built with commit: 427438e58bf70cd0065d34c87b047bb7c49daf1b

@IgnacioBecerra
Copy link
Contributor

I'm assuming actual close captions would replace "Test Video - 1:1 (0:18)" under the video, correct?

@kennylam
Copy link
Member Author

kennylam commented Sep 23, 2020 •
edited
Loading

I'm assuming actual close captions would replace "Test Video - 1:1 (0:18)" under the video, correct?

@IgnacioBecerra It will add the CC button if the video has captions.

image

Currently only working locally, as the Kaltura environment variables for deploy previews needs to be changed to view the videos (examples in any of the CTA video variations).

image

asudoh
asudoh approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @kennylam!

jeffchew
jeffchew approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@jeffchew jeffchew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeffchew jeffchew added the Ready to merge Label for the pull requests that are ready to merge label Sep 24, 2020
@kodiakhq kodiakhq bot merged commit d051621 into carbon-design-system:master Sep 24, 2020
@jeffchew jeffchew mentioned this pull request Sep 24, 2020
Closed
@kennylam kennylam deleted the feat/videoplayer-closed-captions branch October 7, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchew jeffchew jeffchew approved these changes

@asudoh asudoh asudoh approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra

@raphaelamadeu-zz raphaelamadeu-zz Awaiting requested review from raphaelamadeu-zz

@andysherman2121 andysherman2121 Awaiting requested review from andysherman2121

Assignees
No one assigned
Labels
package: services Work necessary for the Carbon for IBM.com services package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennylam @ibmdotcom-bot @IgnacioBecerra @asudoh @jeffchew