fix(footer): fixing the default footer type definition #4017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `Footer` as standalone was causing an issue where the navigation links were not rendering if not defined, and passing in `tall` did not work. This happens specifically in NextJS when building and exporting the statically generated pages (rendering in dev mode appears to be unaffected). The default value for some reason was set as `full`, which is incorrect . This logic now checks if the `type` is set as `tall` or `undefined`, and will render accordingly.
|
Deploy preview created for package Built with commit: e69edb6a57558b35cacd8d66ecb8a2f520a10768 |
|
Deploy preview created for package Built with commit: e69edb6a57558b35cacd8d66ecb8a2f520a10768 |
jeffchew
added
the
Ready to merge
annawen1
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
No related issue
Description
Using the
Footeras standalone was causing an issue where thenavigation links were not rendering if not defined, and passing in
talldid not work. This happens specifically in NextJS whenbuilding and exporting the statically generated pages (rendering in
dev mode appears to be unaffected).
The default value for some reason was set as
full, which is incorrect. This logic now checks if the
typeis set astallorundefined,and will render accordingly.
Changelog
Changed
Footertype definition