Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(card): Remove class form footer to make component clickable #12097

Merged

Conversation

marcelojcs
Copy link
Contributor

Related Ticket(s)

JIRA

Description

PR to solve

Card's shadowroot element matching .cds--card__footer has a pseudo-element that blocks click access to the slotted link.

Changelog

Removed class name from footer wrapper on the card component

@marcelojcs marcelojcs added the test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing label Nov 4, 2024
@marcelojcs marcelojcs requested a review from a team as a code owner November 4, 2024 13:19
Copy link

netlify bot commented Nov 4, 2024

👷 Deploy request for ibm-dotcom-web-components pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 93ce5a5

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 93ce5a5
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/672a8afb371bf90008c9050c
😎 Deploy Preview https://deploy-preview-12097--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 4, 2024

Deploy preview created for package IBM.com Web Components Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12097/index.html

Built with commit: 93ce5a5e7805af47451fd8ef0cb7a471131ab284

@andy-blum andy-blum added the Ready to merge Label for the pull requests that are ready to merge label Nov 5, 2024
@andy-blum andy-blum merged commit 60d3b0a into carbon-design-system:main Nov 5, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge test: CDN preview used for generating @carbon/ibmdotcom-web-components CDN for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants