Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(toggletip): add option for alternate icon #11694

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(toggletip): add option for alternate icon #11694

wants to merge 7 commits into from

Conversation

sangeethababu9223
Copy link
Member

@sangeethababu9223 sangeethababu9223 commented Apr 4, 2024 •
edited
Loading

Related Ticket(s)

Closes #11636

Description

Allow specifying an alternate icon to the Toggletip web component

Changelog

New

  • Added a new attribute option for enabling custom icons - hasCustomIcon
  • Added functionality to check if hasCustomIcon attribute is added to the Toggletip component, if so show the custom icon instead of the default information icon.
  • Added an extra knob in storybook for custom icons.

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner April 4, 2024 06:17
@sangeethababu9223 sangeethababu9223 requested review from emyarod and annawen1 and removed request for a team April 4, 2024 06:17
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 4, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11694/index.html

Built with commit: 756fc1fe79d85db8d8190879b3965b25cc4c8e38

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 4, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11694/index.html

Built with commit: 756fc1fe79d85db8d8190879b3965b25cc4c8e38

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 4, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11694/index.html

Built with commit: 756fc1fe79d85db8d8190879b3965b25cc4c8e38

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11694/index.html

Built with commit: 756fc1fe79d85db8d8190879b3965b25cc4c8e38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow specifying an alternate icon to the Toggletip web component
3 participants
@sangeethababu9223 @ibmdotcom-bot @kennylam