Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(modal): ai updates #11533

Merged
merged 7 commits into from
Feb 16, 2024
Merged

feat(modal): ai updates #11533

merged 7 commits into from
Feb 16, 2024

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

Closes #11500

Description

updates modal to latest AI gradient updates

Changelog

New

  • modal now checks if footer slotted for styles

Changed

  • modal-footer reverted code back to only checking if there are three buttons
  • updated styles

Removed

  • {{removed thing}}

@ariellalgilmore ariellalgilmore added package: carbon web components area: AI Used to filter issues in the Carbon for AI project. labels Feb 13, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 13, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11533/index.html

Built with commit: 4b5e1b7a4060b40a85bf8bad98397d762eeaef4c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 13, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11533/index.html

Built with commit: 4b5e1b7a4060b40a85bf8bad98397d762eeaef4c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 13, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11533/index.html

Built with commit: 4b5e1b7a4060b40a85bf8bad98397d762eeaef4c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 13, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11533/index.html

Built with commit: 4b5e1b7a4060b40a85bf8bad98397d762eeaef4c

aagonzales
aagonzales approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! 🎉

@ariellalgilmore ariellalgilmore marked this pull request as ready for review February 15, 2024 23:40
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner February 15, 2024 23:40
@ariellalgilmore ariellalgilmore requested review from kennylam and sangeethababu9223 and removed request for a team February 15, 2024 23:40
annawen1
annawen1 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Feb 16, 2024
@kodiakhq kodiakhq bot merged commit d60f94a into carbon-design-system:main Feb 16, 2024
12 of 19 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@ariellalgilmore
feat(modal): ai updates (carbon-design-system#11533)
c478781 
### Related Ticket(s)

Closes carbon-design-system#11500 

### Description

updates modal to latest AI gradient updates
### Changelog

**New**

- modal now checks if footer slotted for styles

**Changed**

- modal-footer reverted code back to only checking if there are three buttons
- updated styles

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@aagonzales aagonzales aagonzales approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
area: AI Used to filter issues in the Carbon for AI project. package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WC modal gradient updates
4 participants
@ariellalgilmore @ibmdotcom-bot @aagonzales @annawen1