feat(skeleton-icon): new cwc component #11434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariellalgilmore
requested review from
emyarod and
IgnacioBecerra
and removed request for
a team
|
Deploy preview created for package Built with commit: a6fa8f5f2c5a0bb9f5dd89c59f23010d9aa15220 |
|
Deploy preview created for package Built with commit: a6fa8f5f2c5a0bb9f5dd89c59f23010d9aa15220 |
|
Deploy preview created for package Built with commit: a6fa8f5f2c5a0bb9f5dd89c59f23010d9aa15220 |
|
Deploy preview created for package Built with commit: a6fa8f5f2c5a0bb9f5dd89c59f23010d9aa15220 |
kennylam
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
@ariellalgilmore Looks great! And this component's SB7 story will need to be added to the feature branch, right?
ariellalgilmore
added
the
Ready to merge
kodiakhq
bot
merged commit 30be3c1
into
carbon-design-system:main
12 of 19 checks passed
ariellalgilmore
added a commit
to ariellalgilmore/carbon-for-ibm-dotcom
that referenced
this pull request
Jan 23, 2024
### Related Ticket(s) Closes carbon-design-system#11380 ### Description Adds new skeleton icon component ### Changelog **New** - skeleton icon readme, story, codesandbox examples <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
ariellalgilmore
added a commit
that referenced
this pull request
Jan 31, 2024
* feat(skeleton-icon): new cwc component (#11434) ### Related Ticket(s) Closes #11380 ### Description Adds new skeleton icon component ### Changelog **New** - skeleton icon readme, story, codesandbox examples <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> * feat(skeleton-icon): storybook v7 --------- Co-authored-by: kennylam <[email protected]>
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
### Related Ticket(s) Closes carbon-design-system#11380 ### Description Adds new skeleton icon component ### Changelog **New** - skeleton icon readme, story, codesandbox examples <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
added a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
* feat(skeleton-icon): new cwc component (carbon-design-system#11434) ### Related Ticket(s) Closes carbon-design-system#11380 ### Description Adds new skeleton icon component ### Changelog **New** - skeleton icon readme, story, codesandbox examples <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) --> * feat(skeleton-icon): storybook v7 --------- Co-authored-by: kennylam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes #11380
Description
Adds new skeleton icon component
Changelog
New