feat(icon-button): update story to Storybook v7 #11387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview created for package Built with commit: dfaf7ca816170aaf829c0d6272fe58f93612791c |
kennylam
reviewed
Jan 11, 2024
packages/carbon-web-components/src/components/icon-button/icon-button.stories.ts
Outdated
Show resolved
Hide resolved
kennylam
merged commit 4c81038
into
carbon-design-system:feat/cwc-storybook-7-vite
7 of 13 checks passed
kennylam
added a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
…#11387) * chore(icon-button): update icon-button stories to sb v7 * fix(icon-button): missing default label Co-authored-by: kennylam <[email protected]> --------- Co-authored-by: kennylam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes #11386
Description
Adjustments to icon-button component stories to be compatible with Storybook v7.
Changelog
Changed
closeOnActivation,isSelected, andkinddefaultOpentotrueto align with Reacttooltip-contentcontrol tolabelto align with React