Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content-block/section): update to v2 and spacing updates #11314

Closed
wants to merge 28 commits into from
Closed

fix(content-block/section): update to v2 and spacing updates #11314

wants to merge 28 commits into from

Conversation

IgnacioBecerra
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra commented Jan 3, 2024 •
edited
Loading

This is a new PR that brings back the changes in #10925.

Related Ticket(s)

#10454

Description

In #9819, the spacing for Content Block was adjusted using the v2 specs.

This PR brings those changes into the Carbon for IBM.com v2 branch, as well as accommodating for other component spacing updates.

Changelog

New

  • updated stories for content section adding a children knob to see inner children

Changed

  • the spacing styles for content block and other components

ariellalgilmore and others added 15 commits September 8, 2023 13:47
@ariellalgilmore @IgnacioBecerra
fix(content-block): spacing adjustments (carbon-design-system#9819)
82bf555 
Adjusting top and bottom border and without border spacing. Adjusted components all touching the content-block component. For some had to seperate out react/wc logic

**Changed**

- style update padding to margin

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@IgnacioBecerra
fix(content-block): updating tokens
2b14a56
@IgnacioBecerra
feat(storybook): adding content section playground
af57162
@IgnacioBecerra
Merge branch 'feat/carbon-for-ibm-dotcom-v2' into fix/content-block-s…
bd6142f 
…pacing-v2
@IgnacioBecerra
Merge branch 'feat/carbon-for-ibm-dotcom-v2' into fix/content-block-s…
fcd011d 
…pacing-v2
@IgnacioBecerra
fix(content-block): update spacing
c5fc061
@IgnacioBecerra
fix(content-section): address spacing feedback
0548c33
@IgnacioBecerra
feat(content-block): expose story again
9f4ab6d
@IgnacioBecerra
fix(content-block): add content block
120f9a6
@IgnacioBecerra
Merge branch 'feat/carbon-for-ibm-dotcom-v2' of https://github.com/ca…
ae8fe13 
…rbon-design-system/carbon-for-ibm-dotcom into fix/content-block-spacing-v2
@IgnacioBecerra
fix(carousel): addressed updates
78c5330
@IgnacioBecerra
fix(prettify): ran yarn format
70c36dc
@IgnacioBecerra
Merge branch 'feat/carbon-for-ibm-dotcom-v2' of https://github.com/ca…
d877403 
…rbon-design-system/carbon-for-ibm-dotcom into fix/content-block-spacing-v2
@IgnacioBecerra
fix(link-list): remove unneeded import
19d3601
@IgnacioBecerra
Merge branch 'feat/carbon-for-ibm-dotcom-v2' into fix/content-block-s…
a389228 
…pacing-v2
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11314/index.html

Built with commit: 68e22f5e31daba038f66acf39f443b6e5e85289b

@IgnacioBecerra IgnacioBecerra marked this pull request as ready for review January 3, 2024 21:06
@IgnacioBecerra IgnacioBecerra requested a review from a team as a code owner January 3, 2024 21:06
@IgnacioBecerra IgnacioBecerra requested review from kennylam and sangeethababu9223 and removed request for a team January 3, 2024 21:06
@IgnacioBecerra IgnacioBecerra changed the title Fix/content block spacing v2 fix(content-block/section): update to v2 and spacing updates Jan 3, 2024
@IgnacioBecerra IgnacioBecerra added Needs design approval PRs on feature requests and new components have to get design approval before merge. v2 labels Jan 3, 2024
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 3, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11314/index.html

Built with commit: 68e22f5e31daba038f66acf39f443b6e5e85289b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11314/index.html

Built with commit: 68e22f5e31daba038f66acf39f443b6e5e85289b

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11314/index.html

Built with commit: 68e22f5e31daba038f66acf39f443b6e5e85289b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Needs design approval PRs on feature requests and new components have to get design approval before merge. v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IgnacioBecerra @ibmdotcom-bot @ariellalgilmore