feat(minify shadowroots): add rollup-plugin-minify-html-literals

[marcelojcs]

Related Ticket(s)

Jira ticket

Description

Adds rollup-plugin-minify-html-literals to the build pipeline. This minifies the HTML resulting from each component's render() function.

Changelog

Changed

• Added rollup-plugin-minify-html-literals to rollup config

[ibmdotcom-bot]

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11207/index.html

Built with commit: 1edf75316f26caa3a73ec69f7708a50429c8faf5

[andy-blum]

There's a change needed to the table-of-contents component. See here

[ibmdotcom-bot]

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11207/index.html

Built with commit: 1edf75316f26caa3a73ec69f7708a50429c8faf5

[ibmdotcom-bot]

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11207/index.html

Built with commit: 1edf75316f26caa3a73ec69f7708a50429c8faf5

[andy-blum]

@marcelojcs make sure to run yarn ci-check from the project root. It's pointing out the errors in the ci-check job.

carbon-for-ibm-dotcom/packages/carbon-web-components/src/components/checkbox/checkbox-story.ts
Warning:   13:10  warning  'ifDefined' is defined but never used  @typescript-eslint/no-unused-vars

[m4olivei]

I added the test: CDN preview tag and closed / reopened to get that build triggered so we can compare bundle sizes.

Otherwise, just minor notes from a static code review.

Will come back and look at the build results when ready.

[ibmdotcom-bot]

Deploy preview created for package Deploy Preview CDN:
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11207/index.html

Built with commit: 1edf75316f26caa3a73ec69f7708a50429c8faf5

[m4olivei]

Now that the deploy preview is done, I don't actually see a difference in bundle size. Perhaps I should be checking some other way? Examples I looked at:

https://1.www.s81c.com/common/carbon-for-ibm-dotcom/version/v2.0.0/search.min.js
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11207/search.min.js

https://1.www.s81c.com/common/carbon-for-ibm-dotcom/version/v2.0.0/filter-panel.min.js
https://ibmdotcom-cdn.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11207/filter-panel.min.js

In both examples the bundles are the same size 🤷.

[andy-blum]

The impact of this change likely won't reflect in bundle sizes, but should appear in total node counts.

Card Group with Card-In-Card demos:

• Current v2
• This PR Preview

Current

This PR

[andy-blum]

Note that the above comment is only testing the rollup changes which affect the CDN assets, not the gulp changes that impact the npm packages.

[ibmdotcom-bot]

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11207/index.html

Built with commit: 1edf75316f26caa3a73ec69f7708a50429c8faf5

[kennylam]

This package doesn't seem to exist. Is this the one you meant to include?

[kennylam]

Also, is this PR a duplicate of #11207?

[m4olivei]

Also, is this PR a duplicate of #11207?

This PR is #11207. Do you mean #11216? #11216 is against the v1 branch, wheras this one is against main, I believe that's the only difference, but @marcelojcs and/or @bruno-amorim can correct me if I'm wrong.

[kennylam]

Do you mean #11216? #11216 is against the v1 branch

Oops, pasted the wrong link. Yep I was referring to 11216, but totally missed the different target branches. Got it now, thanks!

[andy-blum]

The gulp-minify-html-literals package was from here. I'm not sure why that package no longer exists, but we can remove it from this PR.

This PR is also on hold, pending the project's update to Lit v3 because that version seems to have scooped up the underlying minify-html-literals project.