New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #8275, cta style/contentBlockSimple #11055

Closed

yafira wants to merge 2 commits into carbon-design-system:main from yafira:fix/cta-style

yafira commented Oct 19, 2023 •

edited

Loading

Related Ticket(s)

Closes #8275

Description

I looked into #8275 and it seems that the issue reporter was wrong and indeed if contentBlockSimple component is given the cta-style prop with value text, the text now shows as well as an icon. There isn't a bug and I am making a change so that the next person doesn't get confused; I created a new knob cta-text, gave the component a new prop (copy) in the story, and modified the value of an existing prop (heading) in the story.

Screenshot 2023-11-01 at 12 47 35 PM

Changelog

Changed

created a new knob cta-text
modified an existing prop heading
gave the component a new prop (copy) in the story


          issue carbon-design-system#8275, cta style/contentBlockSimple

b6cfe21

yafira requested a review from a team as a code owner

October 19, 2023 21:47

yafira requested review from emyarod and annawen1

October 19, 2023 21:47

Contributor

github-actions bot commented Oct 19, 2023 •

edited

Loading

DCO Assistant Lite bot All Contributors have signed the CLA.

Author

yafira commented Oct 19, 2023

I have read the DCO document and I hereby sign the DCO.

Author

yafira commented Oct 19, 2023

recheck

Contributor

ibmdotcom-bot commented Oct 19, 2023 •

edited

Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11055/index.html

Built with commit: 3219921934dfff298704690ff5d692d502207847

Contributor

ibmdotcom-bot commented Oct 19, 2023 •

edited

Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11055/index.html

Built with commit: 3219921934dfff298704690ff5d692d502207847

Contributor

ibmdotcom-bot commented Oct 19, 2023 •

edited

Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11055/index.html

Built with commit: 3219921934dfff298704690ff5d692d502207847

Contributor

ibmdotcom-bot commented Oct 19, 2023 •

edited

Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11055/index.html

Built with commit: 3219921934dfff298704690ff5d692d502207847

Contributor

ibmdotcom-bot commented Oct 19, 2023 •

edited

Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11055/index.html

Built with commit: 3219921934dfff298704690ff5d692d502207847


          Merge branch 'main' into fix/cta-style

Member

kennylam commented Mar 21, 2024

@yafira Unfortunately the @carbon/ibmdotcom-react package has been deprecated and no longer supported. Thanks so much for your contribution!

kennylam closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet