Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deprecated): remove v1 deprecated components #10979

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Sep 27, 2023

Related Ticket(s)

Closes #10980

Description

We have deprecated components in v1 that have been deprecated for years now. This PR removes those components for v2.

Screenshot 2023-09-26 at 9 36 47 AM

Changelog

Removed

  • removed files and references to card-section-images, image-with-caption, content-group-horizontal, feature-card-block-large, feature-card-block-medium

@annawen1 annawen1 added package: web components Work necessary for the IBM.com Library web components package v2 labels Sep 27, 2023
@annawen1 annawen1 requested a review from a team as a code owner September 27, 2023 17:20
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 27, 2023

@annawen1 annawen1 linked an issue Sep 27, 2023 that may be closed by this pull request
@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam merged commit eca9eb1 into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Sep 29, 2023
4 of 15 checks passed
@kennylam kennylam deleted the chore/remove-deprecated-components branch September 29, 2023 14:47
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Oct 17, 2023
…tem#10979)

* chore(deprecated): removing deprecated components from v1

* chore(migration): update migration docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2: Remove deprecated v1 components
3 participants