Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): fix tests for ci-check #10954

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Sep 19, 2023

Related Ticket(s)

Closes N/A

Description

Ci-check/check-packages test was failing - this PR clears that up

Changelog

New

  • {{new thing}}

Changed

  • {{changed thing}}

Removed

  • {{removed thing}}

@annawen1 annawen1 requested a review from a team as a code owner September 19, 2023 15:48
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 19, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 19, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 19, 2023

@annawen1 annawen1 added package: web components Work necessary for the IBM.com Library web components package v2 labels Sep 19, 2023
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @annawen1!

@annawen1 annawen1 merged commit f78f1c2 into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Sep 20, 2023
@annawen1 annawen1 deleted the chore/ci-check-test-fixes branch September 20, 2023 13:56
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants