Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card-link): update v2 #10953

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

Closes #10751

Description

v2 updates

Changelog

New

  • add link as an option to card
  • confirm disabled works

@ariellalgilmore ariellalgilmore added package: web components Work necessary for the IBM.com Library web components package v2: prep preparation items for Carbon for IBM.com V2 labels Sep 18, 2023
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner September 18, 2023 20:59
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 18, 2023

@ariellalgilmore ariellalgilmore changed the title feat(card-link): updaate v2 feat(card-link): update v2 Sep 18, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 18, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 18, 2023

Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Glad to see the card-link component finally getting replaced 🙌 .
Just a couple things:

Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise!

@ariellalgilmore ariellalgilmore merged commit 4d1ee6e into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Sep 21, 2023
4 of 7 checks passed
@ariellalgilmore ariellalgilmore deleted the feat/card-link branch September 21, 2023 15:46
This was linked to issues Sep 22, 2023
@oliviaflory
Copy link
Contributor

Finally took a look and it's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package v2: prep preparation items for Carbon for IBM.com V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] Card v2 - Storybook [Component] Card link
4 participants