Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(card-static): update v2 styles #10944

Merged
merged 8 commits into from
Sep 18, 2023
Merged

feat(card-static): update v2 styles #10944

merged 8 commits into from
Sep 18, 2023

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Sep 15, 2023 •
edited
Loading

Related Ticket(s)

Closes #10244

Description

card static style updates v2
Screenshot 2023-09-15 at 10 01 55 AM

Changelog

Changed

  • updated color styling and spacing
  • confirmed card-pictogram linverse arrow svg uses correct color
  • also fixes storybook error happening with the copy for all cards

@ariellalgilmore ariellalgilmore added package: web components Work necessary for the IBM.com Library web components package v2: prep preparation items for Carbon for IBM.com V2 labels Sep 15, 2023
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner September 15, 2023 17:03
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 15, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10944/index.html

Built with commit: 608dbb80c2e85726ee4e9370fd60ba159ab7e028

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 15, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10944/index.html

Built with commit: 608dbb80c2e85726ee4e9370fd60ba159ab7e028

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 15, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10944/index.html

Built with commit: 608dbb80c2e85726ee4e9370fd60ba159ab7e028

kennylam
kennylam approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Sep 18, 2023
@ariellalgilmore
Copy link
Member Author

merging in so I can open a PR for card-link

@ariellalgilmore ariellalgilmore merged commit de094c0 into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Sep 18, 2023
3 of 7 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/card-static-v2 branch September 18, 2023 18:52
This was linked to issues Sep 22, 2023
[Component] Card v2 - Storybook #10920
Closed
[Component] Card – static v2 WC #10244
Closed
@RichKummer
Copy link

@ariellalgilmore this looks great! The only issue I noticed was some extra spacing between the heading+eyebrow section and everything below that. Should be 64px (unless it needs to grow in a group), but currently it looks like the margin values are stacking.

Screenshot 2023-10-09 at 12 03 17 PM

Specs:
Screenshot 2023-10-09 at 12 33 13 PM

@RichKummer RichKummer mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
Needs design approval PRs on feature requests and new components have to get design approval before merge. package: web components Work necessary for the IBM.com Library web components package v2: prep preparation items for Carbon for IBM.com V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] Card v2 - Storybook [Component] Card – static v2 WC
4 participants
@ariellalgilmore @ibmdotcom-bot @RichKummer @kennylam