Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(card): v2 card style updates #10903

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Sep 1, 2023

Related Ticket(s)

Closes #10329

Description

Updates default Card to v2 styles

NOTE: when switching video variation in storybook, you may need to refresh the browser for the video duration to load properly

See design specs for details

Image

Changelog

New

  • {{new thing}}

Changed

  • {{changed thing}}

Removed

  • {{removed thing}}

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 1, 2023

@annawen1 annawen1 linked an issue Sep 1, 2023 that may be closed by this pull request
23 tasks
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 1, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Sep 1, 2023

@annawen1 annawen1 added Needs design approval PRs on feature requests and new components have to get design approval before merge. v2 package: web components Work necessary for the IBM.com Library web components package labels Sep 1, 2023
@annawen1 annawen1 marked this pull request as ready for review September 1, 2023 20:34
@annawen1 annawen1 requested a review from a team as a code owner September 1, 2023 20:34
@oliviaflory
Copy link
Contributor

oliviaflory commented Sep 5, 2023

@annawen1 looking good! A few things:

Interactive states

  • Hover: Can you double check the hover color for the card is $layer-hover-01
    It looks a bit dark compared to the specs (right side of the screen shot)
Screenshot 2023-09-05 at 2 24 20 PM
  • Focus: Slight shift in icon position when you tab into card
    Card-icon-shift-Sep-05-2023 14-29-48

CTA Types

  • Video: No text color change on hover for the video time stamp
    Keep text color at $text-primary
Screenshot 2023-09-05 at 2 03 33 PM

Themes

  • Tags are not following dark theme when I change the Theme setting in Storybook
    Tags are currently set to the white or g10 theme, they should follow the correct theme colors for Gray 90 or Gray 100
Screenshot 2023-09-05 at 2 32 35 PM Screenshot 2023-09-05 at 2 33 32 PM

Storybook (not sure how much control you have other these things?)

  • Storybook errors out when I try to add body copy to the Card. (Spacing looks correct for the brief moment I can see it though!)
    Card-story-body-Sep-05-2023 14-08-10

  • Storybook holds onto displaying the video time stamp when I select CTA type Video, then choose another PDF, Blog. I have to refresh the page to get the time stamp to go away.
    Card-video-cta-story-Sep-05-2023 14-15-00

@annawen1
Copy link
Member Author

annawen1 commented Sep 7, 2023

@oliviaflory I created another ticket to capture the Storybook issues: [Component] Card v2 - Storybook #10920

Copy link
Contributor

@oliviaflory oliviaflory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @annawen1 LGTM!

@annawen1 annawen1 removed the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Sep 12, 2023
@annawen1 annawen1 merged commit cd84259 into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Sep 12, 2023
3 of 14 checks passed
@annawen1 annawen1 deleted the feat/card-v2 branch September 12, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] Card v2 updates
3 participants