Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lerna): build packages & codesandbox updates #10876

Merged
merged 2 commits into from
Aug 24, 2023
Merged

fix(lerna): build packages & codesandbox updates #10876

merged 2 commits into from
Aug 24, 2023

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Aug 24, 2023 •
edited by annawen1
Loading

Related Ticket(s)

none

Description

This specifies which packages lerna should build, so when publishing we can ignore CWC and handle it seperately. This will prevent CWC v1 from overriding the latest npm tag.

Also updated codesandbox examples to point to v1-latest tag

Changelog

New

  • {{new thing}}

Changed

  • {{changed thing}}

Removed

  • {{removed thing}}

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner August 24, 2023 16:01
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 24, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10876/index.html

Built with commit: 001c073aa8e3bbba047047a60e48bc207cef5b29

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 24, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10876/index.html

Built with commit: 001c073aa8e3bbba047047a60e48bc207cef5b29

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 24, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10876/index.html

Built with commit: 001c073aa8e3bbba047047a60e48bc207cef5b29

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 24, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10876/index.html

Built with commit: 001c073aa8e3bbba047047a60e48bc207cef5b29

@ariellalgilmore ariellalgilmore merged commit fa5bee0 into carbon-design-system:main Aug 24, 2023
m4olivei pushed a commit to m4olivei/carbon-for-ibm-dotcom that referenced this pull request Aug 31, 2023
@ariellalgilmore @m4olivei
fix(lerna): build packages & codesandbox updates (carbon-design-syste…
71d46e5 
…m#10876)
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@ariellalgilmore
fix(lerna): build packages & codesandbox updates (carbon-design-syste…
fcbb303 
…m#10876)
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@ariellalgilmore
fix(lerna): build packages & codesandbox updates (carbon-design-syste…
599472b 
…m#10876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariellalgilmore @ibmdotcom-bot @annawen1