Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image): v2 updates #10810

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

Closes #10750

Description

Update image component to v2 specs

Changelog

New

  • lightbox-contrast (light or dark) prop

Changed

  • reduced styles to just the _image.scss file

Removed

  • image with caption

@ariellalgilmore ariellalgilmore added package: web components Work necessary for the IBM.com Library web components package v2: prep preparation items for Carbon for IBM.com V2 labels Aug 10, 2023
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner August 10, 2023 16:57
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 10, 2023

@ariellalgilmore ariellalgilmore marked this pull request as draft August 10, 2023 17:56
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 10, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 10, 2023

@ariellalgilmore ariellalgilmore marked this pull request as ready for review August 10, 2023 23:32
@annawen1
Copy link
Member

looks like we need to update the snapshots!

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick change @ariellalgilmore 🎉

@ariellalgilmore ariellalgilmore merged commit 7627a86 into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Aug 15, 2023
@ariellalgilmore ariellalgilmore deleted the feat/image-v2 branch August 15, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package v2: prep preparation items for Carbon for IBM.com V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants