Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gh): clean up ci-check workflow #10370

Merged

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Apr 21, 2023

Description

This adds @svgr/webpack to resolve karma-webpack issues with loading SVGs. These issues were preventing ci-check in web components from completing successfully (for @carbon/ibmdotcom-web-components).

Changelog

New

  • @svgr/webpack package added to ibmdotcom-web-components

Changed

Removed

  • {{removed thing}}

@kennylam kennylam added package: web components Work necessary for the IBM.com Library web components package dependencies Pull requests that update a dependency file labels Apr 21, 2023
@kennylam kennylam requested a review from a team as a code owner April 21, 2023 14:37
@kennylam kennylam requested a review from RichKummer April 21, 2023 14:37
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 21, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Apr 21, 2023

@kennylam kennylam removed the request for review from RichKummer April 21, 2023 15:07
@kennylam kennylam closed this Apr 21, 2023
@kennylam kennylam reopened this Apr 21, 2023
@kennylam kennylam force-pushed the deps/add-svgr-webpack branch from 07b528e to 837bb3c Compare April 21, 2023 15:53
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam merged commit e58d8d5 into carbon-design-system:feat/cwc-v2 May 2, 2023
@kennylam kennylam deleted the deps/add-svgr-webpack branch May 2, 2023 15:05
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
* chore(gh): clean up ci-check workflow

* chore(snapshot): udpate cwc snapshots

---------

Co-authored-by: Anna Wen <[email protected]>
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
* chore(gh): clean up ci-check workflow

* chore(snapshot): udpate cwc snapshots

---------

Co-authored-by: Anna Wen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file package: web components Work necessary for the IBM.com Library web components package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants