Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[card link] Hover when disabled #9815

Closed
2 tasks done
RichKummer opened this issue Dec 8, 2022 · 3 comments
Closed
2 tasks done

[card link] Hover when disabled #9815

RichKummer opened this issue Dec 8, 2022 · 3 comments
Assignees
Labels
bug Something isn't working dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package

Comments

@RichKummer
Copy link

Description

When card link is disabled, it should not have a hover state when a user places their cursor over the card link. Currently, the component darkens when the user hovers over it.

See current:
https://user-images.githubusercontent.com/15643582/206571769-9891a708-f1a1-4094-80de-fc811d669ead.mov

Component(s) impacted

card link

Browser

Chrome

Carbon for IBM.com version

v.1.25.0

Severity

Severity 4 = The problem is not visible to or noticeable to an average user. Affects minor functionality, no workaround needed.

Application/website

C4IBM.com

Package

@carbon/ibmdotcom-web-components

CodeSandbox example

https://codesandbox.io/s/github/carbon-design-system/carbon-for-ibm-dotcom/tree/main/packages/web-components/examples/codesandbox/components/card-link

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@RichKummer RichKummer added bug Something isn't working dev Needs some dev work labels Dec 8, 2022
@RichKummer RichKummer changed the title [YOUR TITLE]: Brief description [card link] Hover when disabled Dec 8, 2022
@oliviaflory oliviaflory added the package: styles Work necessary for the Carbon for IBM.com styles package label Dec 12, 2022
@RichKummer RichKummer added the package: web components Work necessary for the IBM.com Library web components package label Dec 12, 2022
@kennylam kennylam self-assigned this Dec 21, 2022
@kennylam
Copy link
Member

@RichKummer this is the standard behavior for disabled links and is consistent with core Carbon styles. See example here.

@oliviaflory
Copy link
Contributor

@kennylam The cursor change is consistent with the core Carbon styles, but I think the darkening of the card background (probably $ui-hover) shouldn't happen if it's disabled.

@kennylam
Copy link
Member

Ah, got it!

kodiakhq bot pushed a commit that referenced this issue Jan 13, 2023
### Related Ticket(s)

#9815

### Description

Removes hover styles from `disabled` card links.

### Changelog

**New**

- add disabled hover styles to card links

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work package: styles Work necessary for the Carbon for IBM.com styles package package: web components Work necessary for the IBM.com Library web components package
Projects
None yet
Development

No branches or pull requests

6 participants